ansi_color_converter no longer necessary on windows10 (IDFGH-10726)

Question

ansi_color_converter no longer necessary on windows10 (IDFGH-10726)

phed opened this issue a year ago · comments

Both miniterm and idf_monitor tries to convert terminal escape codes into windows terminal calls. This is no longer necessary as the default installed windows terminal now supports VT100.

This means one can have much more complex terminal interactions. miniterm already makes the necessary calls to enable it.

I haven't found a simple way to disable it, so I've just modified it to pass through the serial output. I am not familiar enough with the code to make a patch.

More about the windows terminal VT100 support here:
https://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences

Roland Dobai · Answer 1 · Tue Jul 25 2023 13:46:01 GMT+0800 (China Standard Time)

Thanks @phed for raising this suggestion. One should be always cautious with dropping support for older technologies. We will give this a careful consideration....

phed · Answer 2 · Thu Jul 27 2023 02:45:59 GMT+0800 (China Standard Time)

Happy to hear. One can detect if the full VT100 support exists through the mechanism suggested under "Example of Enabling Virtual Terminal Processing". Of course one has to check if any possible initialization done by miniterm does not conflict with such a detection.

Frantisek Hrbata · Answer 3 · Mon Jul 31 2023 16:28:43 GMT+0800 (China Standard Time)

Hello, IIUC the console can be still put into legacy mode. I don't know about a use case for this, but I'm not a windows user neither. That being said, if someone needs to use, for whatever reason, legacy console, he may run into problems with idf monitor. Just my $0.02.