es-shims / get-own-property-symbols

ES6 Object.getOwnPropertySymbols partial polyfill

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Thoughts on omitting `for` and `keyFor`?

ljharb opened this issue · comments

Symbol.for and Symbol.keyFor can't be shimmed cross-realm, which is one of its primary purposes.

What would you think about removing those methods entirely?

If not, then at least it should be a documented caveat in the README.

will put them in the README too. Agreed, cross-realm is a whole new world of messness for any sort of polyfill.

I've updated this and other caveats ... if that's OK for you please close this bug.

Thanks

Looks good, thanks