erwindon / SaltGUI

A web interface for managing SaltStack based infrastructure.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Issues screen is ignoring states for which at least one task failed

erwindon opened this issue · comments

Describe the bug
The Issues screen is ignoring states for which at least one task failed, but for which the last task succeeded.

To Reproduce
Steps to reproduce the behaviour:

  1. Create a state with multiple tasks for the same state
  2. Let the last task succeed
  3. Go to 'Issues'
  4. See that the state is not reported

Expected behaviour
Any state with at least one failed task should be reported

Additional context
The original code assumes that each state has exactly one task.
That is a wrong assumption.

Reproduce
Use state:

state1:
  cmd.run:
    - names:
      - "true"
      - "true"
      - "false"

This is a single state named state1.
But it has 3 tasks: true, true and false.

Solution
report each failed task individually.
but note that the retry-action will still re-apply the whole state.