For the future 23.1 use tag 23.1.0
tsloughter opened this issue · comments
@getong I'm opening this as a note in case I miss the future PR when 23.1 is released.
Discussing in the Build and Packaging Working Group led to the conclusion that the smallest change necessary to get others on board with using these images instead of duplicating work and causing community confusion would be to add that final .0 to the version when a minor release is made. Also for a major release, meaning when 24 comes out the tags would be, 24, 24.0 and 24.0.0.
I realized I don't really know how the different versions are pushed and tagged. It is a manual process with a PR to add a new tag, like 23.1.0 and then how does it know to create 23 and 23.1 as well?
The generate-stackbrew-library.sh script outputs all the tags like:
Tags: 23.0.2, 23.0, 23, latest
Architectures: amd64, arm32v7, arm64v8, i386, s390x, ppc64le
GitCommit: ed3bd9400e1b72b2bdd08596990f8ed3350a75c0
Directory: 23
But travis only builds, it does not push, and then runs that official-images/test/run.sh with the image name/tag of the image built.
I don't see a push in that test script either but may have missed it if its calling out to other scripts in their official-images repo.
On a side note, we can move the manual process part to be a a github action as part of the erlang/otp repo. But we can worry about that after this.