ericoporto / agstoolbox

🧰Utility Adventure Game Studio software to help manage, install, and uninstall different AGS Editor versions.

Home Page:https://www.adventuregamestudio.co.uk/forums/index.php?topic=59938.0

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add a MANIFEST.in for setuptools

ericoporto opened this issue · comments

A MANIFEST.in necessary to properly package the distribution for PyPI because python packaging defaults are terrible - it doesn't recursively package the modules in agstoolbox module and it selects apparently by version dependant chance wth goes in.

Seven years ago my MANIFEST.in looked like this : https://github.com/ericoporto/fgmk/blob/master/MANIFEST.in

Apparently it's still good enough as a reference.

Testing find packages from setuptools also didn't correctly got all submodules, so we want to name all of them in the setup.py too, under packages.

It's probably a good idea to also mimic all of this in the toml project file in case one day we migrate to that.

Marking as a bug since PyPI installs are broken until this is fixed.

PyPI is fixed by e9e3032

Still need to fix the toml project at some point. Didn't need to add to MANIFEST.in, but had to specifically add all submodules in setup.py