Giters

ericnewton76 / gmaps-api-net

C# google maps api interface for interacting with the backend web services for Google Maps

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Wrong conversion for PlaceType in PlaceRequests

ergunozyurt opened this issue · comments

commented

Hi,

The only PlaceType conversion for Places API requests is in PlaceRequest/TypesToUri which doesn't do anything to fit google place types. (https://developers.google.com/places/supported_types)

Google API returns non-filtered results when the given types don't match their types. So, we don't see any error with the request but get wrong result set.

commented

Hi @ergunozyurt, looking at the code it seems that we might not be not converting PlaceType enums that contain multiple words correctly, but ones with a single word in them should work.

Ie, PlaceType.AmusementPark should be converted to amusement_park, but currently gets converted to amusementpark.

Does that match what you are seeing?

commented

Hi @richardthombs, exactly.
I'll subscribe notifications of #84 , thanks!