Requesting new test with a cowboy branch
essen opened this issue · comments
Can you try this branch for Cowboy? I'm wondering how much of a bottleneck this is. I always knew it was one but I don't know by how much.
https://github.com/essen/cowboy/tree/no-bottleneck
Thanks.
yeah, I can run a c1k test locally for you.
C1K test for 240 seconds; times are milliseconds
Handshake Times
Mean Min Median 75% 95% 99% 99.9% Max
no-bottleneck 1.630112 0.824000 0.992000 1.035000 1.170000 31.853410 42.679039 42.718000
0.6.0 1.485211 0.792000 0.978000 1.043000 1.152100 26.596530 37.605235 37.840000
Latencies
Mean Min Median 75% 95% 99% 99.9% Max
no-bottleneck 0.1897586 0.0870000 0.1720000 0.2090000 0.2720000 0.5550000 1.0619900 1.7150000
0.6.0 0.1996201 0.0910000 0.1920000 0.2270000 0.2860000 0.4640000 0.6000000 1.8290000
Counts:
type, clients, handshakes, connection_timeouts, messages_sent, messages_recv, crashes
"0.6.0", 1000, 1000, 0, 119402, 119402, 0
"no-bottleneck", 1000, 1000, 0, 119403, 119403, 0
This doesn't make much sense... but I forgot one change, sorry. I'll push again and inform you. Thanks!
Pushed. :)
cool, I'll rerun the no-bottleneck one
C1K test for 240 seconds; times are milliseconds
"Handshake Times"
Mean Min Median 75% 95% 99% 99.9% Max
no-bottleneck 1.630112 0.824000 0.992000 1.035000 1.170000 31.853410 42.679039 42.718000
no-bottleneck2 3.487267 0.815000 0.967000 1.013000 3.886000 80.518060 92.199513 92.712000
0.6.0 1.485211 0.792000 0.978000 1.043000 1.152100 26.596530 37.605235 37.840000
"Latencies"
Mean Min Median 75% 95% 99% 99.9% Max
no-bottleneck 0.1897586 0.0870000 0.1720000 0.2090000 0.2720000 0.5550000 1.0619900 1.7150000
no-bottleneck2 0.2135 0.0910 0.1990 0.2370 0.3230 0.5720 1.2000 3.1730
0.6.0 0.1996201 0.0910000 0.1920000 0.2270000 0.2860000 0.4640000 0.6000000 1.8290000
I don't get it. They all run with {max_connections, infinity}, right?
All I did was deleted deps/cowboy and change rebar to using your branch. Let me see if the server is using {max_connections, infinity}
I'll check if I didn't forget something. Thanks.
I shouldn't have to recompile competition/wsdemo.erl right? I just recompiled deps/cowboy
Yeah just deps/cowboy. I'll investigate things.