Decimal.compare produces the wrong result for some cases

Question

vshev4enko opened this issue a year ago · comments

Some cases:

iex(41)> Decimal.compare("0.1234", 0)
:lt

not a lot, we use only one number for testing

Wilhelm Kirschbaum · Answer 1 · Wed Apr 26 2023 21:26:47 GMT+0800 (China Standard Time)

Our tests lit up with failures after the update. Can confirm the above:

Elixir 1.14.4 (compiled with Erlang/OTP 25)
Decimal 2.1.0

Decimal.lt? and Decimal.gt? are also broken, but they seem to rely on compare/2

Eric Meadows-Jönsson · Answer 2 · Wed Apr 26 2023 22:22:27 GMT+0800 (China Standard Time)

Closing in favor of #197.

@vshev4enko @wkirschbaum Can you confirm the PR branch works in your applications?

@mzigora @willemodendaal Also CCing you, would appreciate all help in testing this.

Viacheslav Shevchenko · Answer 3 · Wed Apr 26 2023 22:38:01 GMT+0800 (China Standard Time)

yes, works in my applications

Wilhelm Kirschbaum · Answer 4 · Wed Apr 26 2023 23:27:44 GMT+0800 (China Standard Time)

@ericmj All previously failed tests on our side passes with the above fix. 200+ tests using Decimal, so fairly confident this works. 😍

Eric Meadows-Jönsson · Answer 5 · Wed Apr 26 2023 23:31:22 GMT+0800 (China Standard Time)

Thank you for reporting back! I will do a bugfix release today.