Update plugin to work with Grunt 0.4.0

Question

Update plugin to work with Grunt 0.4.0

jgrund opened this issue 11 years ago · comments

Joe Grund commented 11 years ago

Consider making a separate branch and update the plugin to work with grunt 0.4.0.

This could be done on a separate branch.

Right now when running the task in grunt 0.4.0rc7, I get the following error:

Warning: Object #<Object> has no method 'expandDirs' Use --force to continue.

Eric Clemmons commented 11 years ago

Will do!

Eric Clemmons · Answer 1 · Sat Jan 26 2013 09:51:15 GMT+0800 (China Standard Time)

@jgrund Nice commit! Can you issue a PR, or would you prefer that I just git cherry-pick it?

Joe Grund · Answer 2 · Mon Jan 28 2013 23:11:33 GMT+0800 (China Standard Time)

@ericclemmons Yes, I will issue a PR shortly.

Joe Grund · Answer 3 · Mon Jan 28 2013 23:13:38 GMT+0800 (China Standard Time)

Actually, could you create a new branch to merge into so I don't merge the 0.4 changes into master?

Eric Clemmons · Answer 4 · Mon Jan 28 2013 23:22:07 GMT+0800 (China Standard Time)

Isn't it OK to merge 0.4 changes into master? I thought 0.4 and 0.3.x should work together, or at least several of the grunt-contrib-* do...

On Monday, January 28, 2013 at 9:13 AM, Joe Grund wrote:

Actually, could you create a new branch to merge into so I don't merge the 0.4 changes into master?

—
Reply to this email directly or view it on GitHub (#5 (comment)).

Joe Grund · Answer 5 · Mon Jan 28 2013 23:24:37 GMT+0800 (China Standard Time)

There are a number of breaking changes between 0.3 and 0.4. Check out this Upgrade Guide for more info.