FinalMethodRule

Question

FinalMethodRule

Slamdunk opened this issue 5 years ago · comments

Filippo Tessarotto commented 5 years ago

Hi, following FinalRule for classes I would propose FinalMethodRule for public methods of abstract classes, see https://slamdunk.github.io/blog/when-to-declare-methods-final/

I have a phpstan-extension package too but yours is more focused on strictness, so such a rule would fit better here.

Would you consider a PR for this topic?

Filippo Tessarotto · Answer 1 · Fri May 17 2019 21:21:13 GMT+0800 (China Standard Time)

Of course the rule would only be active with:

parameters:
	allowAbstractClasses: true

Andreas Möller · Answer 2 · Fri May 17 2019 21:39:08 GMT+0800 (China Standard Time)

Love it, great idea!

Filippo Tessarotto · Answer 3 · Fri May 17 2019 21:58:20 GMT+0800 (China Standard Time)

Have I already spotted a use-case?
https://github.com/localheinz/phpstan-rules/blob/51d8c8ebc14ef4dec045db03de309aebd2097343/test/Integration/AbstractTestCase.php#L44
😃

Filippo Tessarotto · Answer 4 · Wed May 22 2019 15:57:52 GMT+0800 (China Standard Time)

Note to self: related PHP-CS-Fixer rule https://github.com/Slamdunk/php-cs-fixer-extensions/blob/v1.19.0/lib/FinalAbstractPublicFixer.php

stale · Answer 5 · Sun Jul 21 2019 16:46:19 GMT+0800 (China Standard Time)

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.