Giters

epfml / error-feedback-SGD

SGD with compressed gradients and error-feedback: https://arxiv.org/abs/1901.09847

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cannot find 'TemporarilyAddMemory'

201419 opened this issue · comments

commented

Hi, your work is so great!

There is a small problem here. I can't find TemporarilyAddMemory this file, but you used from optimizers.TemporarilyAddMemory import TemporarilyAddMemory in the 22nd line of the main.py file.

https://github.com/epfml/error-feedback-SGD/blob/master/main.py#L22

Have you forgotten to upload this file ?

commented

Thanks for pointing this out! We indeed forgot to clean up our code properly. For now, just commenting out this line should fix the issue. Let me know if it works :)

commented

You're welcome. I found class TemporarilyAddMemory in the /utils/convex_opt.py file.

You are right and I can fix it by commenting out this line.

Still have to say, your work is so great！