Wrong v51 release (Gnome 44) & versioning issue
pakaoraki opened this issue · comments
After some investigation on #222, I figure out that the bug #285 is back for Gnome 44 (Fullscreen inhibit gets stuck due to a race condition) with the version v51 from gnome extension page.
In fact, the fix is missing and after a quick comparison, it's seams that's the code from gnome-shell-43-44 branch is not the one from the version v51 available.
I'm also a bit confuse about the mismatch between version in GitHub repository and gnome extension page:
- for
Gnome 45: v50 is v52. - for
Gnome 44: v49 is v51.
The metadata.json file have been rewritten by a tool named SweetTooth: so I guess it's part of the release process but I'm not very familiar with it.
@eonpatapon : can you confirm the issue with v51 release please ?
The
metadata.jsonfile have been rewritten by a tool namedSweetTooth: so I guess it's part of the release process but I'm not very familiar with it.
Yea, the bundle gets unzipped, the metadata is rewritten by SweetTooth and then it's repacked. Regardless of the number you give as the version, SweetTooth will strip it out and replace it with the next numerical version, following on from the last uploaded release (including rejected uploads).
Maybe we could match the github version number with the release ? what do you think ?
Makes sense to do it. I had to do that to my extensions a few times in the past anyway.
I'm trying to have the same versions, but it's not easy as when you upload to e.g.o it will not use the version defined in the metadata, it will just take the next integer of the previous upload. It's easy to mess things up when you re-upload, upload for an old version etc...