Times adjustable

Question

Times adjustable

horga83 opened this issue a year ago · comments

Hello,

I love this app well done and thank you. I have one small nit pick, I really don't care for applications that choose defaults such as times of 5, 10 and 30 minutes without providing a way to adjust them. Would you please consider adding this.

I find the defaults of no use to me, 30, 60 an 120 would be more usable for what I do. Being able to adjust our own times would be a desirable feature.

Thank you

pakaoraki · Answer 1 · Wed Feb 08 2023 02:44:17 GMT+0800 (China Standard Time)

To be honest, this feature come from the Caffeine tile of LineageOS, I personally find it very useful on my phone Caffeine for LineageOS, and I took the same amount of time they use: 5, 10 and 30 minutes.

Going for adjustable times is doable, but it would cost a bit more code. If you need to inhibit the system for an hour or more, then maybe it make more sens to manually toggle it. I am not against this as I am not against changing default standard value, but sometimes it's also nice to set some limit to customization.

Could be nice to know if more people is interested by this request feature, I can make it happen. What do you think @eonpatapon , @stuarthayhurst ?

horga83 · Answer 2 · Wed Feb 08 2023 02:49:34 GMT+0800 (China Standard Time)

Thank you for your reply. Might I suggest changing it to 15, 30 and 60. 5 minutes, I expect, is below or equal to the normal screen blank time for most people anyway. I have my timeout set to 10 minutes. A person with a screen blank time of 5 minutes would find the 5 minute setting pointless I would think. On a phone it probably makes more sense. Anyway thank for considering this. George

…

On Tue, 2023-02-07 at 10:44 -0800, pakaoraki wrote: To be honest, this feature come from the Caffeine tile of LineageOS, I personally find it very useful on my phone Caffeine for LineageOS, and I took the same amount of time they use: 5, 10 and 30 minutes. Going for adjustable times is doable, but it would cost a bit more code. If you need to inhibit the system for an hour or more, then maybe it make more sens to manually toggle it. I am not against this as I am not against changing default standard value, but sometimes it's also nice to set some limit to customization. Could be nice to know if more people is interested by this request feature, I can make it happen. What do you think @eonpatapon , @stuarthayhurst ? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: <eonpatapon/gnome-shell-extension- ***@***.***>

Stuart Hayhurst · Answer 3 · Wed Feb 08 2023 03:00:34 GMT+0800 (China Standard Time)

I'd agree changing them to 15, 30 and 60 minutes would probably be more helpful. 5 minutes is a little short to be useful, and 30 minutes is a little short as a maximum. Anything more than an hour is probably worth manually toggling anyway, like @pakaoraki mentioned.

There's only a finite number of things that can be reasonably customised, and code needs to be maintained for all supported features, for every supported version of GNOME. Testing on old version of GNOME and keeping compatibility becomes a headache very quickly (from my own extensions), so I'd say it's only worth adding custom times if there are a lot of requests.

horga83 · Answer 4 · Wed Feb 08 2023 03:16:36 GMT+0800 (China Standard Time)

Yes I agree and anyone that really wants that can figure out the source anyway. Thanks George

…

On Tue, 2023-02-07 at 11:00 -0800, Stuart Hayhurst wrote: I'd agree changing them to 15, 30 and 60 minutes would probably be more helpful. 5 minutes is a little short to be useful, and 30 minutes is a little short as a maximum. Anything more than an hour is probably worth manually toggling anyway, like @pakaoraki mentioned. There's only a finite number of things that can be reasonably customised, and code needs to be maintained for all supported features, for every supported version of GNOME. Testing on old version of GNOME and keeping compatibility becomes a headache very quickly (from my own extensions), so I'd say it's only worth adding custom times if there are a lot of requests. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: <eonpatapon/gnome-shell-extension- ***@***.***>

pakaoraki · Answer 5 · Wed Feb 08 2023 06:16:45 GMT+0800 (China Standard Time)

Thanks for the feedback. I didn't realize that, but maybe 5 minutes make less sense on Desktop than on mobile, it's not the same usage. So yeah, why not raising up the default value. It's highly possible that some people would like to keep the current values, some others would prefer something else, anyway I will think about a new setting.

Jean-Philippe Braun · Answer 6 · Thu Feb 09 2023 01:01:43 GMT+0800 (China Standard Time)

I also agree that 15, 30 and 60 minutes might be better default values.

Stuart Hayhurst · Answer 7 · Sat Feb 11 2023 18:34:34 GMT+0800 (China Standard Time)

#229 should take care of this :)

pakaoraki · Answer 8 · Thu Feb 16 2023 02:56:31 GMT+0800 (China Standard Time)

I came up with a new setting in preferences (#230).

Stuart Hayhurst · Answer 9 · Thu Mar 09 2023 06:56:43 GMT+0800 (China Standard Time)

Can this be closed as #230 has been merged?

Guillaume AMAT · Answer 10 · Thu Mar 09 2023 21:36:18 GMT+0800 (China Standard Time)

Does one know when it would be released? 🙏

Jean-Philippe Braun · Answer 11 · Thu Mar 09 2023 22:31:58 GMT+0800 (China Standard Time)

Will probably make a release with gnome 44 support when merged