enzymejs / react-shallow-renderer

Shallow rendering for React.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

React 18 support

zpao opened this issue · comments

In my very very limited use, it doesn't appear to be a problem to just be using React 18 so far, but it would be good to explicitly add 18 to peerDeps if compatible. This would just silence the install time warning.

Sure! Would you like the package version to be bumped to 18.0.0 as well?

I don't work on react anymore and can't speak for the team, but perhaps @gaearon has an opinion?

commented

We didn’t bump it to 17 so maybe let’s not bump to 18 either? So that it doesn’t seem like it’s part of the release or encouraged for use.

We should probably shim the new Hooks though before the bump (to 16.15 or something). There aren’t that many and implementations should be simple.

We should probably shim the new Hooks though before the bump (to 16.15 or something). There aren’t that many and implementations should be simple.

Could you elaborate on what's required here? But I think you should still have npm and GitHub access so feel free to make the necessary changes yourself

commented

I mean providing some shims for useId etc.

Please provide plans to verify merge request above.

it's annoying see every time this picture.

image

commented

Fixed in react-shallow-renderer@16.15.0.