Giters

envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

lose watch when SimpleCache respond return false in respondWithSpecificOrder

firebook opened this issue · comments

commented

For ADS mode, class io.envoyproxy.controlplane.cache.SimpleCache will respond to client when setSnapshot.

When respond(watch, snapshot, group); return false, respondWithSpecificOrder will lose the watch, since respond is not complete, client will not rewatch

`
respond(watch, snapshot, group);

      // Discard the watch. A new watch will be created for future snapshots once envoy ACKs the response.
      return true;

`