envoyproxy / java-control-plane

Java implementation of an Envoy gRPC control plane

ratelimit DescriptorStatus does not implement duration_until_reset defined in data plane api

wwillsey opened this issue 4 years ago · comments

wwillsey commented 4 years ago

Please see:
https://github.com/envoyproxy/java-control-plane/blob/master/api/src/main/proto/envoy/service/ratelimit/v3/rls.proto#L95
whereas, in the envoy data plane api, the rls.proto defines:
https://github.com/envoyproxy/data-plane-api/blob/master/envoy/service/ratelimit/v3/rls.proto#L117

Is this a bug? or was this value intentionally left out?

Jakub Dyszkiewicz commented 4 years ago

I'm pretty sure that is the result of unsynced proto files. We need to update proto files to catch up with Envoy changes

Kateryna Nezdolii commented 4 years ago

+1 on this. I have wip PR for upgrading v3 cluster proto to latest version: #148 (will prioritise for next week).

Krzysztof Słonka commented 3 years ago

duration_until_reset was recently updated: https://github.com/envoyproxy/java-control-plane/blame/master/api/src/main/proto/envoy/service/ratelimit/v3/rls.proto#L117. Closing this issue, if there is something missing please reopen.