Giters

enix / kube-image-keeper

kuik is a container image caching system for Kubernetes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Handling crd's in the helm chart

denniskern opened this issue · comments

commented

Hi all

I had some trouble with the crd's and the actual helm chart respectively install it, de-install and re-install it.
The crd was removed after the re-install and also the cached image objects.

My suggestion is instead of using a variable which controls the installation of the crd's lets use the approach which
helm offers. https://helm.sh/docs/chart_best_practices/custom_resource_definitions/#method-1-let-helm-do-it-for-you

In short: Instead of putting the crd's into the template folder put them into a separate crd folder.
Then helm take care if its needed to install the crd or not.

I would create a PR - What do you think?

commented

Hi @denniskern,

Thanks a lot for your feedback !
We pinpointed this issue/behavior a couple of days back but did not have the opportunity to correct it yet !
Yes, you can create a PR & we’ll have a look at it !

Please, have a look at the small rules depicted here :
https://github.com/enix/kube-image-keeper/blob/main/CONTRIBUTING.md

commented

Thanks for your contribution to the project 🙏
I'll close the issue as it will be available in the next release.