enix / kube-image-keeper

kuik is a container image caching system for Kubernetes

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ImagePullSecrets from ServiceAccounts are not considered for CachedImage

jmueller42 opened this issue ยท comments

Hi,

first of all, thank you for this great tool.

Currently kuik uses the imagePullSecrets: list from the pod spec in order to fill the imagePullSecrets in the CachedImage.
Unfortunately it is also possible to specify imagePullSecrets attached to the serviceAccount which gets attached to the pod.

example pod:

apiVersion: v1
kind: Pod
metadata:
  annotations:
    ...
  labels:
    ...
  name: xyz
  namespace: default
spec:
  containers:
  - name: first
    ...
  serviceAccount: pod-sa
  serviceAccountName: pod-sa
  ...

example pod-sa:

apiVersion: v1
imagePullSecrets:
- name: my-pull-secret
kind: ServiceAccount
metadata:
  name: pod-sa
  namespace: default
  ...

Unfortunately different external helm charts we have to use, use this feature to define the imagePullSecrets.

It would be great if kuik would also read the imagePullSecrets from defined ServiceAccounts.

๐ŸŽ‰ This issue has been resolved in version 1.5.0 ๐ŸŽ‰

The release is available on GitHub release

Your semantic-release bot ๐Ÿ“ฆ๐Ÿš€