enescakir / registration-bot

Register to Bogazici University's courses on the wings of the wind

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

instance vs class variables at registration class

mdegis opened this issue · comments

Out of the box configuration for the most python linters will not like the way you define username, password, debug, session, error and base_url at the registration class.

Turning them all uppercase will suppress the linting error however, when we check the usage, they are called by using self instead of class itself (Registration.base_url for example). This makes me think maybe they should be instance variable instead of class variable. Also since you've already re-assign username and password at the constructor, moving all of them will not change much but will respect the convention a little bit more IMHO.

What do you think? I might be wrong btw 🤔