eneim / toro

Video list auto playback made simple, specially built for RecyclerView

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Video not Pausing/Playing in NestedScrollView

Black4guy opened this issue · comments

What kind of issue is this?
I am using NestedScrollView as a parent layout of recyclerview video not playing/pausing properly

@Black4guy @eneim
I'm also facing same, found any solution for this?

@Black4guy @eneim
I'm also facing same, found any solution for this?

Not yet.

@Black4guy @thiagoricieri @eneim @fossabot
Then what are you using for now?

@imran-samed @Black4guy I have not much experience using RV inside NestedScrollView. Still wondering why RV is used inside NestedScrollView, there are facts we need to face here: If a RV is nested inside a NestedScrollView, either it doesn't work well and the scroll is not smooth anymore, or you need to call setNestedScrollingEnabled to false to make things work well together (as far as I can search through the Internet) but the RV loses the scroll to the NestedScrollView (this case the scroll event will not be reported to Toro, which cause the issue). Also setting this seems to force the RV to render all its children, which is not so good.

I will see how it can be done. But it is not the highest priority at the moment. Please consider to check your layout and see if it can be done without the nesting structure. RV inside RV also works (where both the outer RV and the child RV are Container view).

@Black4guy @imran-samed
Then what are you using for now?

As @eneim suggested in one of answer to use one extra viewholder and put all the components which are inside nestedscrollivew to the Viewholder and remove Nestedscrollview.
This is how i managed that In my case.

@imran-samed @Black4guy I have not much experience using RV inside NestedScrollView. Still wondering why RV is used inside NestedScrollView, there are facts we need to face here: If a RV is nested inside a NestedScrollView, either it doesn't work well and the scroll is not smooth anymore, or you need to call setNestedScrollingEnabled to false to make things work well together (as far as I can search through the Internet) but the RV loses the scroll to the NestedScrollView (this case the scroll event will not be reported to Toro, which cause the issue). Also setting this seems to force the RV to render all its children, which is not so good.

I will see how it can be done. But it is not the highest priority at the moment. Please consider to check your layout and see if it can be done without the nesting structure. RV inside RV also works (where both the outer RV and the child RV are Container view).

Yes,i am completely agree with your points