end2endzone / ShellAnything

ShellAnything is a C++ open-source software which allow one to easily customize and add new options to *Windows Explorer* context menu. Define specific actions when a user right-click on a file or a directory.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Separator visibility options

GasDauMin opened this issue · comments

I wanted to clarify if I understand correctly that the visibility of the separator is not controlled, if it is set, it will be set and there is no possibility to change it. If so, in this case, it would be very important to have the ability to control the visibility of the separator.

As is the case with me, I have described several menu items after the separator, but they are displayed under certain conditions (e.g., exceptions for file extensions, files, directories, etc.) and are not available in this context. Therefore, I would like to be able to control the separator itself.

Separator

You are correct. The visibility of the separator is not controlled. I think that it would be a good addition to ShellAnything.

I do not think it would be that hard to implement. Change the parser to parse visibility/validity elements even when separator="true" is found. Change the menu renderer function BuildMenuTree() to test for visibility/validity even when Menu::IsSeparator() is true.

Would you be able to contribute again with this feature? I would gladly accept a pull request.

I might be able to work again, but it's hard to say when, I was hoping there would be time to work at the time that I accidentally did a commit. But at the same time I started working on a second project, and there was no more free time for hobby coding, as much as I would like to :)

However, I can see that it would not take much time to make the right change, I can do it.