Giters

end2endzone / ShellAnything

ShellAnything is a C++ open-source software which allow one to easily customize and add new options to *Windows Explorer* context menu. Define specific actions when a user right-click on a file or a directory.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove single quote characters surrounding values in ActionExecute logs

end2endzone opened this issue · comments

commented

Is your feature request related to a problem? Please describe.
ActionExecute logs are hard to read and decipher.

In version 0.8, logging is displayed as the following:

I0707 11:32:55.727994 26272 ActionExecute.cpp:250] Exec: 'C:\Windows\system32\cmd.exe'.
I0707 11:32:55.727994 26272 ActionExecute.cpp:253] Arguments: '/k ""ffprobe.exe" -v verbose -hide_banner -i "test.wav""'.
I0707 11:32:55.727994 26272 ActionExecute.cpp:257] Basedir: 'D:\share'.
I0707 11:32:55.731998 26272 ActionExecute.cpp:274] Process created. PID=32956

Describe the solution you'd like

  • Remove single quote characters (') surrounding values in ActionExecute logs. This would greatly improve readability.
  • Replace Exec: logs with Path: to match the name of the xml attribute in configuration files.

Describe alternatives you've considered
N/A

Additional context
N/A

commented

The commit d657874 changes logs to the following format:

I1129 19:52:28.759215 21364 ActionExecute.cpp:250] Path: C:\Windows\System32\calc.exe
I1129 19:52:28.759215 21364 ActionExecute.cpp:257] Basedir: C:\Windows\System32
I1129 19:52:28.769224 21364 ActionExecute.cpp:274] Process created. PID=2980

I1129 19:52:30.568859 21364 ActionExecute.cpp:250] Path: cmd.exe
I1129 19:52:30.568859 21364 ActionExecute.cpp:253] Arguments: /c copy C:\Windows\System32\calc.exe C:\Users\MyUserName\AppData\Local\Temp\my_calc.exe>NUL 2>NUL
I1129 19:52:30.568859 21364 ActionExecute.cpp:257] Basedir: C:\Users\MyUserName\AppData\Local\Temp
I1129 19:52:30.572863 21364 ActionExecute.cpp:274] Process created. PID=1816

I1129 19:52:31.577776 21364 ActionExecute.cpp:168] Path: D:\dev\ShellAnything\build\bin\Debug\sa.tests-d.exe
I1129 19:52:31.577776 21364 ActionExecute.cpp:172] Verb: runas
I1129 19:52:31.577776 21364 ActionExecute.cpp:177] Arguments: --PrintProcessSettings --foobar
I1129 19:52:31.577776 21364 ActionExecute.cpp:182] Basedir: C:\Users\MyUserName\AppData\Local\Temp
I1129 19:52:32.933007 21364 ActionExecute.cpp:194] Process created. PID=2568