enb / enb-bemxjst

bem-xjst support for ENB

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Proposal: add [version] to BEMHTML

Yeti-or opened this issue · comments

In dev build add version prop to BEMHTML instance, with version of bem-xjst we build on.

In bem-xjst@4+ has no dev mode.

We can add option (for example provideVersion: true) and use it in ENB development mode.

@Yeti-or can you provide usecase for version prop?

@miripiruni The same as process.version

@blond Are you sure we should extend BEMHTML instance in dev mode? It's ok for me but also it's strange to hear that from you. 😸

@zxqfox can you describe more? I don’t understand the target issue.

@miripiruni Describe what?) How it's useful to see a version from the repl?

@zxqfox Okay. The only question is: you accidentally do not intend to use it as a "feature detection"?

@miripiruni Well, sure not. But it's useful for debugging and informational purposes.
Anyway I'm against adding this to production build.

Are you sure we should extend BEMHTML instance in dev mode? It's ok for me but also it's strange to hear that from you. 😸

@zxqfox I think every man able to decide where to use option.

I think every man able to decide where to use option.

Liberty is the new freedom, lol.

Any normal developer can do require('bem-xsjt/package.json').version or npm ls | grep bem-xjst.

We don’t need version field and moreover option (provideVersion: true) for this. It’s useless and weird.