enarx / ciborium

CBOR utilities

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Feature]: Implement Read/Write traits for embedded_io::{Read,Write}

elrafoon opened this issue · comments

Is there an existing issue for this?

  • I have searched the existing issues

Description

Dear maintainers,

I think it would be very useful to have support for embedded_io traits right in the ciborium - implement ciborium::{Read,Write} for embedded_io::{Read,Write}.

I have already implemented it, but now I realized one problem - ciborium currently sets MSRV to 1.58.

With rust 1.58, there is no support for optional dependencies (so I can't make embedded-io optional) and also limits embedded-io version to 0.5.0 (while current is 0.6.1).

See pull request

How shall I proceed?

Acceptance Criteria

No response

Suggestions for a technical implementation

No response

I have a PR open to boost the MSRV #103, and it's stuck on an unrelated unit test that fails. I can force it, but I'd appreciate help on trying to figure out the cause.

Closed via #104