Using deprecated macro AC_PROG_LIBTOOL
szpak opened this issue · comments
The work to make network-manager-sstp natively available in Fedora is slowly moving forward. By the way a checked told me that:
[!]: Package should not use obsolete m4 macros
Note: Some obsoleted macros found, see the attachment.
AC_PROG_LIBTOOL found in: NetworkManager-sstp-0.9.10/configure.ac:17
It's not a blocker as I expect to have already generated configure file available in a tarball, but by the way of the further changes you could think about replacing it with LT_INIT.
Thanks for helping out the Fedora project. Do you have any patches that you'd worked on and like to see committed? I am not very familiar with the LT_INIT you are talking about, are you able to collaborate?
Unfortunately I haven't used C and related build tools for years. When I replaced AC_PROG_LIBTOOL with LT_INIT in configure.ac autogen command generated the same configure file. However maybe it was generate from some other file...
With commented out LT_INIT different configure file is generated, so probably the change (from AC_PROG_LIBTOOL to LT_INIT) is safe (configure file does not change in comparison to the current version). I will play with it a little more and probably create a very small PR :).