Giters

enaess / network-manager-sstp

Secure Socket Tunneling Protocol Extention for Network Manager

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

nm-sstp-service.c:validate_gateway fails when a port is appended to the gateway

gtjoseph opened this issue · comments

commented

Line 493 should be...

         if (!isalnum (*p) && (*p != '-') && (*p != '.') && (*p != ':'))

instead of

         if (!isalnum (*p) && (*p != '-') && (*p != '.'))

Also the error message at line 535 should show the value instead of the key...

        _("invalid gateway '%s'"),
         value);

instead of

         _("invalid gateway '%s'"),
         key);

"Invalid gateway 'gateway'" isn't much help. :)

commented

Just committed the change to master branch. Thank you for your suggestions.