emoon / rocket

GNU Rocket Git mirror

Home Page:rocket.sf.net

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remote export of groups broken

pixelmager opened this issue · comments

Only direct tracks get properly exported, tracks nested under a group do not show up, groups end up as a zero-byte file with the name of the group.

...possibly because colons are not allowed in filenames on Windows?

Proposed fix: Change separators to use hashes instead of colons.

TrackData.c, l.55:
static int findSeparator(const char* name)
{
int i, len = strlen(name);

for (i = 0; i < len; ++i)
{
    if (name[i] == '#')
        return i;
}

return -1;

}

Argh! Once again windows filename limits strikes again.

Yeah I guess that could work. I think I would do a check for both : and # then for a while in order to phase out the old one but still have it as compatible.

Another way to solve this is in the sync code (that does the export) just replacing "illegal" characters with _ and do the same when loading and it should work as well.