Please install the required when the 'install' target is called

Question

Please install the required when the 'install' target is called

yurivict opened this issue 5 years ago · comments

yuri@FreeBSD commented 5 years ago

It currently doesn't install anything.

install.sh wouldn't do because it doesn't do the right things:

It uses sudo that isn't needed to install the project
It expects /usr/local/bin to be writable which isn't what should be done to install

The install target should install into $DESTDIR$PREFIX and should never need to use sudo.

thbwd · Answer 1 · Sun Oct 13 2019 23:50:38 GMT+0800 (China Standard Time)

install.sh doesn’t require sudo, it offers to use it if it cannot write into the installation directories.

The directories in which to install are fully customizable. The installer states this every time it is run:

If you prefer different locations you can rerun me and provide me with other locations like so:
	 ./install.sh [binary location] [packages location] [include location]

yuri@FreeBSD · Answer 2 · Mon Oct 14 2019 00:10:00 GMT+0800 (China Standard Time)

The installation process should be fully automatic. There's nobody there to read what the installaion script states.

thbwd · Answer 3 · Mon Oct 14 2019 00:27:08 GMT+0800 (China Standard Time)

Feel free to open a pull request that makes the necessary changes for this to run automatically (if possible in terms of calling install.sh, this is what I wanted to hint at).

yuri@FreeBSD · Answer 4 · Mon Oct 14 2019 00:33:59 GMT+0800 (China Standard Time)

Sorry, I don't have resources. I am only a package maintainer.

Project authors are expected to make projects installable, otherwise users would simply have no chance to even see your software because most people install software using package managers these days.

Karim Vergnes · Answer 5 · Thu Aug 11 2022 23:39:05 GMT+0800 (China Standard Time)

I don't see anything the install.sh script that CMake's install() function can't do, and better.