Custom `loadingIcon` inherits `toast` classes even though it is rendered inside one
samlaycock opened this issue · comments
Looking at the code, I'm not sure if this is intentional or not..?:
Line 200 in 9b0dcae
It means that the custom loadingIcon
is rendered with the toast's classes, which causes a double rendering of styles (background, shadows etc.). I think it would be better if the loadingIcon
prop was completely agnostic to any other external styles, as you've already opted into rendering the loading component yourself entirely anyway?
Example:
![Screenshot 2023-12-25 at 10 18 33](https://private-user-images.githubusercontent.com/93922969/292746872-047549e5-b235-4dcb-bd02-850724399e09.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NTQ5NzEsIm5iZiI6MTcyMTY1NDY3MSwicGF0aCI6Ii85MzkyMjk2OS8yOTI3NDY4NzItMDQ3NTQ5ZTUtYjIzNS00ZGNiLWJkMDItODUwNzI0Mzk5ZTA5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDEzMjQzMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg0ODFkNTk5OTAyZmE0NmEwNzE3OGFmNTcyNjVkNzFiZmNhNTczNjM3MmUwOWVmM2YyMGUxOTMwZDI4MDA0MGYmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lPXnMhsbPbpBi5HgZ1byGndzOueur_nB8B3yS3t0nLg)
Good catch, fixed in #268