emilk / loguru

A lightweight C++ logging library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

some improvement points

amrezaee opened this issue · comments

Hi.
I'm using your lib and it's great but some problems exist.
It's a good thing to add #ifndef before NOMINMAX & WIN32_LEAN_AND_MEAN to prevent macro redefinition in environments where those two are defined.
may be add green color to Info verbosity like many other logging libs or provide a way to customize verbosity colors.
and does logging macros by default support c++ types like string or filesystem::path? i tried it, it worked but i get some portability warnings and supporting that types is a good feature.
thanks.