emilianavt / OpenSeeFace

I would have put up a PR, but I wanted to run this by you real quick because I'm not super familiar with C# and there is a really good chance I just don't have something setup correctly.

OpenSeeVRMDriver.cs seems to have a typing issue, lines below. nowT is a double, but the InterpolatedMap takes a float in that param. I'm more familiar with python, seems like this SHOULD implicitly cast, but Unity and Visual Studio both throw an error. If I cast it as a float inline, Unity seems happy like that.

OpenSeeFace/Examples/OpenSeeVRMDriver.cs

Lines 346 to 348 in 9a6eb20

    
           public void SetPerfectSync(string name, float weight, double nowT, float factor) { 
        
               perfectSyncMap.Store(name.ToUpper(), Mathf.Clamp(weight * factor, 0f, 1f), nowT); 
        
           }

Does this sound like an actual thing, or am I missing something dumb like upgrading some .net stuff?

It looks like I actually forgot to update OpenSeeInterpolation.cs at some point. Thank you for letting me know! It should be fixed now.

Welcome! Thanks for all the hard work you do on this. Every time I dive in to work with vsf or osf, I'm always very impressed!

	public void SetPerfectSync(string name, float weight, double nowT, float factor) {
	perfectSyncMap.Store(name.ToUpper(), Mathf.Clamp(weight * factor, 0f, 1f), nowT);
	}

minor typing problem, or it's just me