PowerBinder's EditDialog's implementation is too Byzantine
emersonrp opened this issue · comments
Having a single edit dialog that has many many chunks in it that are shown and hidden as needed seemed like a good idea at the time. It's causing a torrent of harmless but ugly GTK warnings on Linux from the "invisible" bits having height of -1. The edit dialog should be separate from the edit dialog state, and the actual dialog should be created and destroyed on demand.
Trying to untangle this proved too hairy, and it was not the source of the GTK warnings anyway. Re-implementing this more cleanly would involve decoupling the UI from the state in ways that would probably be saner but would be quite a chore for not so much benefit. Closing this and moving on.