Opening the program with a longer list of CustomBinds takes a while
emersonrp opened this issue · comments
See if there's some way to speed up loading custom binds. Alternatively, restructure to show the window sooner but throw up a "busy" cursor while loading.
Could be the part where the app creates a PowerBinderDialog and PowerBinderEditDialog for like every step in every bind. Need to rework this to reuse the same dialog, maybe?
A quickfix (lazy-create dialogs only when shown) has been implemented on main and will ship with the next release.
Shipped the quickfix. @autobotcoop can you see if you notice any performance gains opening up Profiles with large numbers of custom binds? I suspect it might be noticeably faster.
https://github.com/emersonrp/bindcontrol/releases/tag/v0.17.12.3
If I had to guess, I'd say, a 30-45 second decrease in loading time. Well done.
Oh that's fantastic. I'm going to leave the bug open because I have one more idea for further improvement. Delighted that this one worked out so well.
There was um a bit of a bug with saving Simple Binds created by this quickfix. It's fixed in v0.17.12.5
https://github.com/emersonrp/bindcontrol/releases/tag/v0.17.12.5
I am sad to say that any Profile with Simple Binds that's been saved in the meantime -might- have had the state of those Simple Binds' editing dialogs lost. This isn't terrible if you're not going to edit the steps of the bind, the raw contents are still there, but is still possible data loss, so I'm a bit bummed about that.