Can't set `class=` attribute

Question

Can't set `class=` attribute

amk221 opened this issue 5 years ago · comments

I'm not sure what combination of dependencies causes this, but a simple example of:

<MyComponent class="foo" />

is not rendering the class attribute.... changing to @class fixes it, but that's wrong?

Demo repo with failing test:

https://github.com/amk221/-ember-angle-brackets-in-addon/blob/master/tests/integration/components/my-component-test.js#L13

Robert Jackson · Answer 1 · Thu Apr 11 2019 03:21:47 GMT+0800 (China Standard Time)

Looks like you are hitting the issue reported in emberjs/ember.js#17533. This should have been fixed in ember-source@3.9.1 (by emberjs/ember.js#17870), but it looks like you are already using 3.9.1 and therefore shouldn't have this issue... 🤔

@chancancode - Anything obvious I missed?

Robert Jackson · Answer 2 · Thu Apr 11 2019 03:23:15 GMT+0800 (China Standard Time)

@amk221 - I've kicked off #63 to see if the test we added shows an issue under 3.9...

Andrew Kirwin · Answer 3 · Fri May 10 2019 21:38:44 GMT+0800 (China Standard Time)

👋🏻Any update on this?

Andrew Kirwin · Answer 4 · Tue Aug 20 2019 18:43:25 GMT+0800 (China Standard Time)

Hi again, any idea what I can do to help with this?

Robert Jackson · Answer 5 · Tue Aug 20 2019 23:36:22 GMT+0800 (China Standard Time)

Maybe send in a failing test showing input / output expectations? I was fairly sure that this was fixed...

Andrew Kirwin · Answer 6 · Tue Aug 20 2019 23:42:09 GMT+0800 (China Standard Time)

I did do a failing test in the example repo, but I will try to add one directly to ember-angle-bracket-invocation-polyfill

Andrew Kirwin · Answer 7 · Wed Aug 21 2019 06:27:09 GMT+0800 (China Standard Time)

I've done a bit of digging...

If I install ember-font-awesome into my failing test demo repo, then it passes.
Similarly, if I add my failing test from the demo repo to ember-angle-bracket-invocation-polyfill, and uninstall ember-font-awesome, then that test fails with ember try:one ember-lts-3.8

I realise this is a bit odd and maybe not helpful.

I hope it’s not something stupid. I’d hate it to be a red herring.

Robert Jackson · Answer 8 · Thu Aug 22 2019 02:18:20 GMT+0800 (China Standard Time)

Yikes. That is indeed odd.

Andrew Kirwin · Answer 9 · Thu Aug 22 2019 16:04:06 GMT+0800 (China Standard Time)

Here is a build of ember-angle-bracket-invocation-polyfill without ember-font-awesome

Most builds pass, apart from ember-3.4 and ember-3.8

Andrew Kirwin · Answer 10 · Mon Oct 07 2019 23:11:33 GMT+0800 (China Standard Time)

👋 Being able to set class= as an attribute is a very common requirement...

I'm starting to get a backlog of test failures on travis where this polyfill isn't working. Making it impossible to release new versions of my addons with backwards compatibility.

I'm surprised nobody else is experiencing this

Robert Jackson · Answer 11 · Tue Oct 08 2019 01:14:56 GMT+0800 (China Standard Time)

I'm sorry, I haven't had enough time lately to be able to dig into your demo. I will try to put this back on my queue to dig into, but I'm not sure what that means timeline wise...

Andrew Kirwin · Answer 12 · Tue Oct 08 2019 01:19:19 GMT+0800 (China Standard Time)

That's ok.

In the meantime, I will try to factor out font-awesome from ember-angle-bracket-invocation-polyfill's test suite

Ryan Panning · Answer 13 · Fri Dec 13 2019 07:02:02 GMT+0800 (China Standard Time)

FWIW, I think I'm running into this too. It seems passing class="" into a splattributes isn't working below 3.9. Any chance this polyfill can account for the issue? Or is that something that would need to be backported in ember (which is not likely to happen)?
https://travis-ci.org/froala/ember-froala-editor/builds/624378772