a11yAudit helper doesn't respect default axe options
ondrejsevcik opened this issue · comments
Hi, I have disabled a few rules in my config/environment.js
file, but they are still checked in my tests when using a11yAudit()
helper.
I could load those default options in my test and pass them into the helper, but that doesn't sound right. I would expect that this helper respects my default config.
Or is there any specific reason why it doesn't?
Thanks,
Ondrej
EDIT:
I've prepared simple demonstration in this repo https://github.com/ondrejsevcik/ember-a11-testing-axe-options-bug
Hi guys, would you accept PR that would fix this issue?
Absolutely would :)
@Robdel12 I've submitted PR. When you have a moment, could you please review it? Many thanks 🙏🏽
Closed with #100, thanks @ondrejsevcik!