ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Ability to turn off in specific environment

justwright opened this issue · comments

From the readme:

"With the exception of turnAuditOff, each of the fine-grained component hooks above can instead be defined for ALL components inside of your application's config/environment.js file"

...would it be possible to add the ability to access turnAuditOff as well so that the auditing does not appear in, say, a staging environment?

I see no reason why we couldn't do that. Looking at the original PR comment, it seems like it was originally intended to be configurable. (However, I was not around at that time.)

@BrianSipple do you have remember why turnAuditOff is not globally configurable? Seems like it is much more likely to be used than the other options IMO.

👍 would like this configurable because this module kills the development environment

@trentmwillis I floated the idea of making this configurable at the component level when I initially PR'd the feature. There was a larger group consensus against it, though -- the idea being that it might discourage overall usage of the addon. Now that we're getting more requests to enable this, though, I'd say let's do it!

This feature has been added and released in 0.2.2. You can now set turnAuditOff from within your application's config.