ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Acceptance tests not contained in ember-testing-container

billpull opened this issue · comments

Ember: 2.5.1
ember-cli: 2.4.2
ember-a11y: 0.1.12
ember-a11y-testing: 0.1.6

After installing ember-a11y-testing acceptance tests are no longer contained within #ember-testing-container but take up the entire screen. I can see the offending markup warnings in the console but they aren't reported to the qunit test runner.

It seems to be running the acceptance tests multiple times and then eventually the typical qunit screen appears but without the information in the console. No info in browser console or cli test runner that suggest there is an issue.

full dev deps

"devDependencies": {
    "babel-eslint": "^6.0.0-beta.6",
    "babel-polyfill": "^6.8.0",
    "body-parser": "^1.13.3",
    "broccoli-asset-rev": "^2.2.0",
    "broccoli-stew": "^0.3.5",
    "connect-slow": "^0.2.2",
    "ember-a11y": "0.1.12",
    "ember-a11y-testing": "0.1.6",
    "ember-ajax": "0.7.1",
    "ember-cli": "2.4.2",
    "ember-cli-app-version": "^1.0.0",
    "ember-cli-babel": "^5.1.5",
    "ember-cli-blanket": "0.9.8",
    "ember-cli-dependency-checker": "^1.2.0",
    "ember-cli-deploy": "0.5.1",
    "ember-cli-deploy-olo-pack": "^1.0.4",
    "ember-cli-deprecation-workflow": "0.2.2",
    "ember-cli-document-title": "0.3.0",
    "ember-cli-eslint": "1.6.0",
    "ember-cli-htmlbars": "^1.0.1",
    "ember-cli-htmlbars-inline-precompile": "^0.3.5",
    "ember-cli-inject-live-reload": "^1.3.1",
    "ember-cli-meta-tags": "1.0.2",
    "ember-cli-mirage": "0.1.13",
    "ember-cli-moment-shim": "1.2.0",
    "ember-cli-qunit": "^1.2.1",
    "ember-cli-release": "0.2.8",
    "ember-cli-sri": "^2.1.0",
    "ember-cli-template-lint": "0.4.12",
    "ember-cli-uglify": "^1.2.0",
    "ember-cli-windows-addon": "^1.2.2",
    "ember-data": "^2.4.0",
    "ember-data-url-templates": "0.0.7",
    "ember-disable-proxy-controllers": "^1.0.1",
    "ember-exam": "0.4.4",
    "ember-export-application-global": "^1.0.4",
    "ember-load-initializers": "^0.5.0",
    "ember-modal-dialog": "0.9.0",
    "ember-moment": "6.1.0",
    "ember-object-update": "^0.1.0",
    "ember-resolver": "^2.0.3",
    "ember-sinon": "0.3.0",
    "ember-test-selectors": "0.0.3",
    "ember-truth-helpers": "1.2.0",
    "eslint": "^2.4.0",
    "eslint-config-olo": "^0.1.0",
    "eslint-plugin-flowtype": "^2.19.0",
    "express": "^4.13.3",
    "flow-bin": "^0.32.0",
    "glob": "^5.0.14",
    "loader.js": "4.0.9",
    "lodash": "4.16.4",
    "morgan": "^1.6.1"
  }

So now looking through the code I realize it is intentional is to hide the container while the test is running.

I am still seeing an issue with 0.1.6 where my acceptance tests don't report the violations after running. I found another project using 0.1.3 and targeted that version in my project to check the difference.

in 0.1.6 the violations are logged to the console as just information but in 0.1.3 seeing them logged as errors and being reported in qunit.

Going to attempt to keep stepping up the version to see what might be breaking for me.