Giters

ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

axe.a11yCheck throws errors in nested components

BrianSipple opened this issue · comments

commented

[Note] I think this is actually a larger issue in axe-core -- and I PR'd my proposed changes for it there -- but I also wanted to make a note here for the purposes of cross-referencing and to offer an idea for how we can address it in the meantime...

I'm seeing (so far) two different errors in the console when axe.a11yCheck is called on a form component with nested components:

  1. With a single nested component:
    screen shot 2016-06-17 at 12 59 28 am
  2. With multiple nested components:
    screen shot 2016-06-17 at 12 58 37 am

I resolved it by making these changes in axe-core, however, for our purposes and the way we're using axe.a11yCheck, it seems like we can just as well pass in string of the element ID as a selector with the changes here.

Interestingly, the violations still register everything appears to run as expected -- but then the errors in the console do appear to cause the ember-inspector to crash.

commented

Okay, that's definitely an error in axe-core. I'm trying to get somebody from Deque to look at it. 😄 I'd rather fix this once and for all upstream than work around it here.

commented

Upstream has been resolved. Closing.