Giters

ember-a11y / ember-a11y-testing

A suite of accessibility tests that can be run within the Ember testing framework

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`ember-a11y-testing` updates and simplification

scalvert opened this issue · comments

commented

This addon has largely been left untouched since its initial creation. There have been a number of default Ember blueprint updates (outside of this repo), which were hard to pull in due to it being so out-of-date.

In addition to this, the @ember/test-helpers addon, which is one of the underpinnings of Ember's testing system, had evolved to include some new and useful APIs that could positively impact the direction of this addon. More specifically, the new hooks API could be leveraged to automatically wire up accessibility audits in a hands-off manner, allowing apps and addons to progress their code to being more accessible.

Based on the above, there are a number of updates to this addon that are proposed:

  • Ensure it's up-to-date with the latest blueprint. (#181, #182, #187, #190)
  • Convert to TypeScript. Adding TS allows the APIs to be cleaned up and validated, in terms of this public interfaces. (#184, #204)
  • Update linting. (#188)
  • Converting to use Github actions vs. Travis (faster CI execution). (#192, #193)
  • Convert a11yAudit failure to use throw vs. Ember.assert. (#201)
  • Implement new setupGlobalA11yHooks API, which leverages the new hooks API in @ember/test-helpers. (Issue: #186, PR: #200)
  • Drop support for moduleForAcceptance. This API is deprecated. (#199)
  • Deprecate a11yAuditIf (#203)
  • Remove non-test related components and infrastructure (#205)
  • Implement new reporter system, allowing for the custom reporting of violations (#210)
  • Update README with all API and functional changes (#215)

Once the above are completed this addon should be in a stable state, and a new major version should be released.

commented

All of the above have been merged, so closing this.