embark build --contracts

[Feist Josselin]

Bug Report

Since 5.x embark build --contracts runs the local deployment instead of compiling only the contracts.

Summary

Following the documentation this command should only compile the contracts, and skip any deployment. This feature is particularly useful for third-parties integration, such as Slither.

Since 0.5, this command runs a node, which slows down Slither, and creates issues in our CI.

How to reproduce

$ embark demo
$ cd embark_demo
$ embark build --contracts

Expected behavior

$ embark build --contracts
loading solc compiler...
compiling solidity contracts...
Finished compiling

Actual behavior

$ embark build --contracts
Starting Whisper node in another process
Blockchain node is ready
HTTP Proxy for node endpoint ws://localhost:8546 listening on http://localhost:8555
WS Proxy for node endpoint ws://localhost:8546 listening on ws://localhost:8556
Whisper blockchain node is ready
loading solc compiler...
compiling solidity contracts...
Finished compiling

As you can see in the log, the http proxy starts and Whisper is enabled

[Jonathan Rainville]

@montyly Thanks the issue report. You are right, we start the communication modules and Proxy even though that are not needed. We'll be able to fix it quickly and it should be available in a nightly build soon:tm:
I'll let you know once the fix is there and published

[Feist Josselin]

Great; thank you for the quick answer

[Jonathan Rainville]

Here's the PR if you want to follow when it is merged and published: #2289

[Iuri Matias]

@montyly this has been fixed in 5.2.3