Giters

emailmonday / Cerberus

A few simple, but solid patterns for responsive HTML email templates and newsletters. Even in Outlook and Gmail.

Home Page:https://www.cerberusemail.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

4px below hero image

tzappia opened this issue · comments

commented

There is an extra 4px that the <td> around the hero image occupies. Adding display:block; to the image takes it away. If you'd like I can open a pull request.

commented

@tzappia Maybe!

  1. Which template? All of them?
  2. Which email clients?
  3. How much have you tested this to see if adding a display:block; impacts the intended design?
commented
  1. All templates.
  2. In the default clients that Litmus adds to a builder, all but Outlook on Windows showed the issue.
  3. I ran the same 16 default clients in Litmus with display: block; on the image and none were adversely impacted, and this did resolve the issue.

I'm happy to add more client tests before submitting a PR (well, whatever ones Litmus gives me access to.)

commented

That sounds pretty thorough! If you'd like to submit a PR and attach a few of those Litmus tests, I'd appreciate it. Thanks!