completion-in-region-mode keybindings don't override, breaking minibuffer-visible-completions

[Spencer Baugh]

Issue type

• Bug report

Environment

Emacs version: Emacs 30 (trunk)
Operating System: Linux

Reproduction steps

1. Start Emacs
2. (evil-mode)
3. (setq minibuffer-visible-completions t)
4. M-tab (in normal state) to trigger completions
5. Try using //RET to choose a completion
6. Instead those are bound to the associate evil bindings.

Expected behavior

The //RET bindings from the minor mode should override the evil state.

Actual behavior

The minor mode bindings have no effect.

Further notes

The immediate fix, usable by a user, is:

(add-hook 'completion-in-region-mode-hook #'evil-normalize-keymaps)
(evil-make-overriding-map completion-in-region-mode-map))

Possibly there's some different way to fix it inside the evil core.