Giters

emacs-evil / evil

The extensible vi layer for Emacs.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Replace old- with new-style advice

wasamasa opened this issue · comments

commented

Issue type

  • Enhancement request

Further notes

I've come across the deprecation of old-style advice in the upcoming major Emacs release. Accomodating to this will require the following:

  • Bumping the minimum Emacs version from 24.1 to 24.4 (since that's when nadvice.el was introduced)
  • (Optionally) Removing now obsoleted code not needed in Emacs 24.4 or newer
  • Converting old- to new-style advice (seems to have been tackled by Stefan in #1693 (comment))
commented

Side note: if compatibility with Emacs-24.1 is considered important, it can be preserved (by depending on the nadvice forward-compatibility package available from GNU ELPA).
That's what I have currently on the scratch/evil branch.