Repelling ritual causes massive server lag.
BiggieBeans opened this issue · comments
Hey so I've been using your mod (version 0.2.7) on my All The Mods 6 server and set up a bunch of repelling rituals (5 to be exact) around our base which was super cool until the next day I discovered that the server was now running consistently about 20 full seconds behind. After a few restarts through which the problem persisted I used a performance profiling mod called Spark to determine that 95.59% of cpu time was being used for mob pathfinding, so I removed the rituals and restarted the server to find that the lag was gone. Here's the link to my results: https://spark.lucko.me/#iCXaz9ZPts
I'm pretty sure that most of the ranges on my rituals were overlapping so my personal unfounded theory is that mobs were getting confused and constantly recalculating their pathfinding due to being stuck in these overlaps. Frankly though I have no clue what I'm talking about.
So I came to file this, but it looks like it appears to already be filed. This seems to actually be causing a hang in our world here is a jstack:
It's pretty consistent, and reading the code, it may be in the code block around the mob already having the goal assigned (the mobs in question are trapped in a mob farm)
This issue is also present with the ritual of alluring.
Example of it happening with Llamas
https://spark.lucko.me/QoJQyB5pQx