[DDFG] Add BadInputError for dtype handling
mm-abogdan opened this issue · comments
In the first case, an UnboundLocalError
occurs because data
is not assigned based on the current if/else
criteria. Add an else
clause and raise BadInputError
accompanied by a more informative error handling message.
impyute/impyute/dataset/base.py
Lines 34 to 37 in 2c25368
In the second case, no matter what value you pass through dtype
, no error occurs. This is because, in this instance, data
is assigned immediately. Follow the same logic as above.
impyute/impyute/dataset/base.py
Lines 66 to 70 in 2c25368
Be sure to follow the 4 steps outlined in contributing.md
The below labels are for DDFG (Data Days for Good) participant reference:
Priority: Low
Difficulty: Low