elsmr / mp3-mediarecorder

🎙MediaRecorder ponyfill that records audio as mp3

Home Page:https://mp3-mediarecorder.elsmr.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

AudioContext should not be closed

alexthewilde opened this issue · comments

https://github.com/eliasmeire/mp3-mediarecorder/blob/c154ddcbf94f19cddd7187b5bfe993176cc34ae4/src/recorder/index.ts#L75

Closing the AudioContext here makes it impossible to re-use the context on subsequent recordings.

Removing this line fixes the issue.

I added this to limit the amount of open AudioContexts, if you don't pass in your own AudioContext (to fix #59). I shouldn't close it if you pass in your own AudioContext. I'll make a fix!

🎉 This issue has been resolved in version 4.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀