elm-in-elm / compiler

Elm compiler written in Elm

Home Page:https://elm-in-elm.github.io/compiler/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make the let body see the let bindings

Janiczek opened this issue · comments

Currently if you try to put

module Main exposing (main)

main =
    let
        x = 2
    in
        1 + x

into example-project/src/Main.elm and run it with make, it complains about x not being visible in the body. Make it so!

Depending on where the fix is, it might be a good idea to also add a regression unit test somewhere.

Feel free to discuss/ask how to solve this on our Discord!

I'm taking a look at this right now! Will keep everyone up to date with my progress.

Let's not forget the test.failing( ➡️ test( change in integration tests when this is done: #85 (comment)

CI should fail if we do forget :)

Looks like maybe this is fixed? The contents of Main.elm in example-project are:

module Main exposing (main)

main =
    let
        x = 2
    in
        1 + x

Yup seems like we fixed this as one of the last things before the project took a bit of a hiatus in 2020 😄 Closing 👍