`TypedSvg.Attributes.version` takes a `Float`

Question

`TypedSvg.Attributes.version` takes a `Float`

zakvdm opened this issue 7 years ago · comments

Zak van der Merwe commented 7 years ago

Probably not a big deal, but seems like this should either be String or a new type.

Rupert Smith · Answer 1 · Wed May 10 2017 18:13:31 GMT+0800 (China Standard Time)

May be best as a String.

Rupert Smith · Answer 2 · Tue Aug 15 2017 19:32:07 GMT+0800 (China Standard Time)

Going with a String instead of introducing a new type. There are two official values this can take "1.0" and "1.1". However there are some variations that some browsers may accept and it seems nicer to allow the user to put anything in here to allow for experimentation.

Alexander · Answer 3 · Tue Aug 15 2017 21:12:58 GMT+0800 (China Standard Time)

@rupertlssmith @zakvdm
I suppose this typed version would be better:

type Version 
    = Version_1_0
    | Version_1_1
    | VersionCustom String