elm-community / typed-svg

Typed SVG library written for Elm

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should use xlink:href and not href?

rupertlssmith opened this issue · comments

https://github.com/elm-community/typed-svg/blob/master/src/TypedSvg/Attributes.elm#L1144

The comment says:

"The xlinkHref attribute is used before SVG 2 but is now rendered obsolete by href."

But this seems bad advice since SVG 2 is never really completed? The standard is still SVG 1.1 if you want compatibility, so should use "xlink:href"?

Solution: Just change the comment to suggest using xlink:href, if the above is correct.