elm-community / graph

Functional Graph Library in Elm.

Home Page:http://package.elm-lang.org/packages/elm-community/graph/latest

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Upgrade to elm 0.19

jhrcek opened this issue · comments

Hello @sgraf812,
now that elm 0.19 it would be nice to have this library upgraded for it.

So far I tried elm-upgrade which resolves most of the dependency/core functions renaming. After that some manual steps are needed:

  • get rid of variable shadowing (simple)
  • Remove occurrences of Debug.crash (in some cases I'm unsure how to proceed)
  • Migrate tests to the new elm-explorations/test (should be simple too).

Are you planning to work on that in the weeks to come? If not I could start working on it, but I'd ask for some input regarding those Debug.crashes.

I'd love if you would take the lead on this.

I need this too! I've upgraded a few libraries already, so I'll give it a shot.

Ok, I've got it all updated and running. There were a few tricky parts, but I think it works as intended. I did have to make a major semvar changes though on a few function's signatures (see the PR comments).

Fixed in #21, incurring a new dependency on elm/json.